Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Automate releases with goreleaser #404

Merged
merged 2 commits into from
Mar 8, 2022
Merged

feat: Automate releases with goreleaser #404

merged 2 commits into from
Mar 8, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Mar 7, 2022

This bundles coder, coderd, and provisionerd inside a single binary: coder. The size is ~180MB for the fat version, which doesn't seem terrible. If the size turns out to be a burden, we can always ship the slim version, which doesn't package any additional assets. It's so large because it contains Coder binaries for multiple platforms for agents to run.

Developers on Mac, Windows, and Linux can install Coder and fully test it out before committing to a production installation. This enables tinkering like never before!

@kylecarbs kylecarbs self-assigned this Mar 7, 2022
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #404 (430e8aa) into main (e1205a0) will increase coverage by 2.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #404      +/-   ##
==========================================
+ Coverage   66.02%   68.33%   +2.31%     
==========================================
  Files          71      158      +87     
  Lines         774     9228    +8454     
  Branches       73       73              
==========================================
+ Hits          511     6306    +5795     
- Misses        249     2301    +2052     
- Partials       14      621     +607     
Flag Coverage Δ
unittest-go-macos-latest 62.70% <100.00%> (?)
unittest-go-ubuntu-latest 67.38% <100.00%> (?)
unittest-go-windows-2022 62.03% <100.00%> (?)
unittest-js 66.02% <ø> (ø)
Impacted Files Coverage Δ
site/embed.go 83.14% <ø> (ø)
cli/daemon.go 82.43% <100.00%> (ø)
cli/root.go 84.72% <100.00%> (ø)
cli/clitest/clitest.go 93.33% <0.00%> (ø)
cryptorand/strings.go 90.32% <0.00%> (ø)
codersdk/parameters.go 62.50% <0.00%> (ø)
pty/ptytest/ptytest.go 100.00% <0.00%> (ø)
cli/projects.go 77.41% <0.00%> (ø)
httpmw/httpmw.go 100.00% <0.00%> (ø)
httpmw/apikey.go 84.34% <0.00%> (ø)
... and 80 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1205a0...430e8aa. Read the comment docs.

@kylecarbs kylecarbs marked this pull request as ready for review March 8, 2022 00:06
Comment on lines +21 to +23
# The "trimprefix" appends ".exe" on Windows.
post: |
cp {{.Path}} site/out/bin/coder_{{ .Os }}_{{ .Arch }}{{ trimprefix .Name "coder" }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neato 👍

.goreleaser.yml Outdated Show resolved Hide resolved
.goreleaser.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@bryphe-coder bryphe-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is one of my favorite features of go, that we can bundle all the platforms up into a single fat binary. Cool idea!

@kylecarbs kylecarbs merged commit 3eb6fb7 into main Mar 8, 2022
@kylecarbs kylecarbs deleted the release branch March 8, 2022 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants