Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Test flake for resolving instance identity auth #405

Merged
merged 1 commit into from
Mar 8, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Mar 8, 2022

@kylecarbs kylecarbs self-assigned this Mar 8, 2022
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #405 (2c8e8b7) into main (18c929c) will increase coverage by 2.40%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
+ Coverage   66.02%   68.42%   +2.40%     
==========================================
  Files          71      158      +87     
  Lines         774     9227    +8453     
  Branches       73       73              
==========================================
+ Hits          511     6314    +5803     
- Misses        249     2292    +2043     
- Partials       14      621     +607     
Flag Coverage Δ
unittest-go-macos-latest 62.70% <ø> (?)
unittest-go-ubuntu-latest 67.31% <ø> (?)
unittest-go-windows-2022 62.21% <ø> (?)
unittest-js 66.02% <ø> (ø)
Impacted Files Coverage Δ
provisioner/echo/serve.go 60.00% <0.00%> (ø)
httpmw/workspaceresourceparam.go 59.18% <0.00%> (ø)
coderd/users.go 61.53% <0.00%> (ø)
cli/users.go 100.00% <0.00%> (ø)
codersdk/workspaceresourceauth.go 62.50% <0.00%> (ø)
provisioner/terraform/provision.go 74.87% <0.00%> (ø)
codersdk/files.go 66.66% <0.00%> (ø)
cli/clitest/clitest.go 93.33% <0.00%> (ø)
pty/start_other.go 72.00% <0.00%> (ø)
httpmw/workspaceagent.go 47.36% <0.00%> (ø)
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 18c929c...2c8e8b7. Read the comment docs.

@kylecarbs kylecarbs merged commit e1205a0 into main Mar 8, 2022
@kylecarbs kylecarbs deleted the identityflake branch March 8, 2022 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants