fix: Make deploy use new build scripts #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #406 +/- ##
==========================================
- Coverage 68.57% 68.18% -0.40%
==========================================
Files 155 158 +3
Lines 9048 9228 +180
Branches 73 73
==========================================
+ Hits 6205 6292 +87
- Misses 2244 2309 +65
- Partials 599 627 +28
Continue to review full report at Codecov.
|
bryphe-coder
reviewed
Mar 8, 2022
Comment on lines
-13
to
-15
| # Once `provisionerd` is available, we'll also need that binary | ||
| # COPY bin/provisionerd /provisionerd | ||
| # RUN chmod +x /provisionerd |
There was a problem hiding this comment.
Thanks for updating this!
bryphe-coder
reviewed
Mar 8, 2022
| cp ./images/coder/run.sh ./bin | ||
| docker build --network=host -t us-docker.pkg.dev/coder-blacktriangle-dev/ci/coder:latest -f images/coder/Dockerfile ./bin | ||
| cp ./images/coder/run.sh ./dist/coder_$(GOOS)_$(GOARCH) | ||
| docker build --network=host -t us-docker.pkg.dev/coder-blacktriangle-dev/ci/coder:latest -f images/coder/Dockerfile ./dist/coder_$(GOOS)_$(GOARCH) |
There was a problem hiding this comment.
Sorry I missed this in your other PR where the binaries changed - we don't have a test for this yet, unfortunately (deploy isn't checked at all on PRs).
We could add a smoke test where we run the docker image and verify that we can curl and get the login page, to help make it easier to catch these in the future
bryphe-coder
approved these changes
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.