fix: MacOS PTY flake when reading after command exists #410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The TTY wasn't bufferring properly because the FD was closed. I did this initially to clone how creack/pty handles it, but it's unnecessary because we get the entire PTY back to close.
deansheather
approved these changes
Mar 8, 2022
Codecov Report
@@ Coverage Diff @@
## main #410 +/- ##
==========================================
+ Coverage 68.23% 68.26% +0.02%
==========================================
Files 158 158
Lines 9228 9225 -3
Branches 73 73
==========================================
Hits 6297 6297
+ Misses 2307 2304 -3
Partials 624 624
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TTY wasn't buffering properly because the FD was closed.
I did this initially to clone how creack/pty handles it, but it's
unnecessary because we get the entire PTY back to close.
I tested this on my Mac by adding a
time.Sleepbetween spawning a command and reading its output, and theio.EOFoccurred every time.