Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update ICE dependency to fix test flake #413

Merged
merged 1 commit into from
Mar 8, 2022
Merged

fix: Update ICE dependency to fix test flake #413

merged 1 commit into from
Mar 8, 2022

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs self-assigned this Mar 8, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) March 8, 2022 18:27
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #413 (a8da101) into main (45daa44) will increase coverage by 2.62%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
+ Coverage   66.02%   68.64%   +2.62%     
==========================================
  Files          71      158      +87     
  Lines         774     9232    +8458     
  Branches       73       73              
==========================================
+ Hits          511     6337    +5826     
- Misses        249     2275    +2026     
- Partials       14      620     +606     
Flag Coverage Δ
unittest-go-macos-latest 63.17% <ø> (?)
unittest-go-ubuntu-latest 67.85% <ø> (?)
unittest-go-windows-2022 62.00% <ø> (?)
unittest-js 66.02% <ø> (ø)
Impacted Files Coverage Δ
coderd/provisionerdaemons.go 59.96% <0.00%> (ø)
httpmw/workspaceagent.go 47.36% <0.00%> (ø)
pty/pty_windows.go 68.25% <0.00%> (ø)
codersdk/workspaces.go 52.72% <0.00%> (ø)
httpmw/workspaceparam.go 76.47% <0.00%> (ø)
site/embed.go 83.14% <0.00%> (ø)
httpmw/httpmw.go 100.00% <0.00%> (ø)
cli/projectplan.go 62.50% <0.00%> (ø)
provisioner/echo/serve.go 57.50% <0.00%> (ø)
database/db.go 55.17% <0.00%> (ø)
... and 77 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45daa44...a8da101. Read the comment docs.

Copy link
Contributor

@bryphe-coder bryphe-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kylecarbs kylecarbs merged commit 1d889c3 into main Mar 8, 2022
@kylecarbs kylecarbs deleted the icedepup branch March 8, 2022 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants