fix(site): rm duplicate mask-icon; refactor(site): reorder <head> #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/favicon.svg should 404, but it's also a duplicate of the mask-icon that has crossorigin="use-credentials" refactor(site): link attribute ordering I believe the former duplication of rel="mask-icon" was because the crossorigin and rel attributes made it less readable.
refactor(site): reorder link and meta tags refactor(site): reorder link and meta tags
Codecov Report
@@ Coverage Diff @@
## main #425 +/- ##
==========================================
+ Coverage 68.03% 68.19% +0.16%
==========================================
Files 159 159
Lines 9226 9226
Branches 73 73
==========================================
+ Hits 6277 6292 +15
+ Misses 2325 2312 -13
+ Partials 624 622 -2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
There was a duplicate
rel=mask-icontag inhtml_templates/index.html. First and foremost, this was fixed in 2eca17e. The source of the confusion was likely that therelattribute was in a different order for the case whereby we specifiedcrossorigin, so I re-arranged those attributes.Then, to make v2 match v1, I re-orderd the meta and link tags at large in a4b56cc to be in the same order (grouping meta and links rather than interleaving them).
Impact of change
There's likely no harm in having two
rel=mask-icontags, I imagine only one (not sure which) gets picked up by Apple. But it's certainly unnecessary and a tad confusing. Overall this is mostly a quality of life refactor and v1 -> v2 parity.