Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add linter for typescript code #45

Merged
merged 5 commits into from
Jan 21, 2022
Merged

Conversation

bryphe-coder
Copy link
Contributor

  • Add and configure eslint
  • Add to build pipeline
  • Fix lint failures

@bryphe-coder bryphe-coder self-assigned this Jan 21, 2022
@codecov
Copy link

codecov bot commented Jan 21, 2022

Codecov Report

Merging #45 (1cd83f2) into main (2654a93) will increase coverage by 0.04%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #45      +/-   ##
==========================================
+ Coverage   70.00%   70.04%   +0.04%     
==========================================
  Files          48       48              
  Lines        2167     2170       +3     
  Branches        9        9              
==========================================
+ Hits         1517     1520       +3     
- Misses        505      506       +1     
+ Partials      145      144       -1     
Flag Coverage Δ
unittest-go-macos-latest 66.36% <ø> (+0.42%) ⬆️
unittest-go-ubuntu-latest 69.60% <ø> (-0.45%) ⬇️
unittest-go-windows-latest 66.14% <ø> (+0.37%) ⬆️
unittest-js 64.70% <33.33%> (-0.63%) ⬇️
Impacted Files Coverage Δ
site/pages/_app.tsx 0.00% <0.00%> (ø)
site/pages/index.tsx 0.00% <0.00%> (ø)
site/theme/theme.tsx 100.00% <ø> (ø)
site/components/Navbar/index.tsx 100.00% <100.00%> (ø)
peer/conn.go 75.07% <0.00%> (-0.61%) ⬇️
peerbroker/dial.go 77.27% <0.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2654a93...1cd83f2. Read the comment docs.

.eslintrc.yaml Outdated
ecmaVersion: 2018
project:
- "./tsconfig.json"
- "./lib/ts/coderapi/tsconfig.json"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can prob remove a buncha these

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh ya, good catch - definitely

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed with 8084f0d

@bryphe-coder bryphe-coder merged commit 7b9347b into main Jan 21, 2022
@bryphe-coder bryphe-coder deleted the bryphe/chore/lint-frontend branch January 21, 2022 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants