Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add CODEOWNERS #459

Merged
merged 2 commits into from
Mar 16, 2022
Merged

chore: add CODEOWNERS #459

merged 2 commits into from
Mar 16, 2022

Conversation

greyscaled
Copy link
Contributor

Summary:

Partial port of v1 CODEOWNERS -> v2

Impact:

Coder FE will be pinged to review changes in site. We do not have a check that
requires an explicit approval, but it helps review cycle iteration

Summary:

Partial port of v1 CODEOWNERS -> v2

Impact:

Coder FE will be pinged to review changes in site. We do not have a check that
requires an explicit approval, but it helps review cycle iteration
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #459 (ddbb5a1) into main (d8e530e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #459   +/-   ##
=======================================
  Coverage   67.90%   67.90%           
=======================================
  Files         159      159           
  Lines        9262     9262           
  Branches       83       83           
=======================================
  Hits         6289     6289           
  Misses       2350     2350           
  Partials      623      623           
Flag Coverage Δ
unittest-go-macos-latest 62.57% <ø> (-0.07%) ⬇️
unittest-go-ubuntu-latest 67.45% <ø> (+0.02%) ⬆️
unittest-go-windows-2022 62.30% <ø> (-0.05%) ⬇️
unittest-js 62.37% <ø> (ø)
Impacted Files Coverage Δ
peer/conn.go 77.23% <0.00%> (-3.33%) ⬇️
coderd/provisionerdaemons.go 57.60% <0.00%> (+0.54%) ⬆️
provisionerd/provisionerd.go 77.94% <0.00%> (+0.55%) ⬆️
peer/channel.go 85.96% <0.00%> (+2.33%) ⬆️
provisioner/echo/serve.go 57.50% <0.00%> (+2.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8e530e...ddbb5a1. Read the comment docs.

Copy link
Contributor

@bryphe-coder bryphe-coder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for adding this!

@greyscaled greyscaled enabled auto-merge (squash) March 16, 2022 06:53
@greyscaled greyscaled merged commit 5a42e17 into main Mar 16, 2022
@greyscaled greyscaled deleted the vapurrmaid/cowners branch March 16, 2022 07:00
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants