Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CLI - Add log for daemon start #464

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Conversation

bryphe-coder
Copy link
Contributor

While going through the manual CLI flow with some people on the team, there was some confusion with the coder daemon command - the fact there was no output to confirm that the daemon started:

coder ~/coder (bryphe/fix/daemon-log) $ dist/coder_linux_amd64/coder daemon

This PR just adds a simple log to confirm that the daemon has started:

coder ~/coder (bryphe/fix/daemon-log) $ dist/coder_linux_amd64/coder daemon
2022-03-16 17:57:20.358 [INFO]  <daemon.go:53>  daemon started  {"url": "http://127.0.0.1:3000"}

Just throwing this out there. Feel free to reject if you have concerns about adding this @kylecarbs !

Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me!

@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #464 (9f450bc) into main (810b2d2) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #464      +/-   ##
==========================================
- Coverage   68.17%   68.11%   -0.07%     
==========================================
  Files         160      160              
  Lines        9258     9260       +2     
  Branches       79       79              
==========================================
- Hits         6312     6307       -5     
- Misses       2325     2331       +6     
- Partials      621      622       +1     
Flag Coverage Δ
unittest-go-macos-latest 62.66% <100.00%> (+0.11%) ⬆️
unittest-go-ubuntu-latest 67.53% <100.00%> (-0.22%) ⬇️
unittest-go-windows-2022 62.11% <100.00%> (-0.31%) ⬇️
unittest-js 63.64% <ø> (ø)
Impacted Files Coverage Δ
cli/daemon.go 82.89% <100.00%> (+0.46%) ⬆️
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
peerbroker/dial.go 75.43% <0.00%> (-7.02%) ⬇️
provisionerd/provisionerd.go 77.94% <0.00%> (-1.48%) ⬇️
peer/conn.go 79.53% <0.00%> (+0.25%) ⬆️
coderd/provisionerdaemons.go 58.15% <0.00%> (+0.54%) ⬆️
database/db.go 68.96% <0.00%> (+13.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 810b2d2...9f450bc. Read the comment docs.

@bryphe-coder bryphe-coder merged commit 8b12e47 into main Mar 16, 2022
@bryphe-coder bryphe-coder deleted the bryphe/fix/daemon-log branch March 16, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants