Add Chocolatey publishing #4706
Conversation
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
panekj
force-pushed
the
feat/chocolatey-builds
branch
3 times, most recently
from
df56dee
to
9cd2f31
Compare
panekj
changed the title
| set -e | ||
|
|
||
| function choco { | ||
| mono /opt/chocolatey/choco.exe "$@" --allow-unofficial --nocolor |
There was a problem hiding this comment.
Instead of running this in mono in a docker container, could this just run on a windows runner instead? A similar PR for winget had the idea of just running this publish step post-publish by using
on:
release:
types: [published]Then we could just use runs-on: windows-latest, install chocolatey and use it the normal way.
There was a problem hiding this comment.
Probably, I've initially reused work from other project I maintain where it just runs as GitHub action as container
panekj
force-pushed
the
feat/chocolatey-builds
branch
from
9cd2f31
to
cfda410
Compare
|
Since exe installer has been added, I've removed MSI building but let me know if you would be still interested in it |
|
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
|
Thanks for sending in the pull-request @panekj I'm going to have a look/review after lunch. A quick note to say haven't forgotten! |
| && chmod +x build.sh zip.sh \ | ||
| && ./build.sh -v \ | ||
| && mv ./code_drop/chocolatey/console /opt/chocolatey \ |
There was a problem hiding this comment.
@ghuntley these steps shouldn't be necessary. Manually building Chocolatey is no longer required, as we ship a Docker Image ready to be used: https://hub.docker.com/u/chocolatey
| set -e | ||
|
|
||
| function choco { | ||
| mono /opt/chocolatey/choco.exe "$@" --allow-unofficial --nocolor |
There was a problem hiding this comment.
If you switch to using the official Docker image, usage of --allow-unofficial will not be required.
Co-authored-by: Gary Ewan Park <gep13@gep13.co.uk>
ghuntley
force-pushed
the
feat/chocolatey-builds
branch
from
9018d8f
to
99e8656
Compare
|
Needs to be moved to |
|
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
Fixes #3714
You need to set secret
CHOCOLATE_KEYwith API key from Chocolatey