Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: windows winget package auto update on every release #4761

Merged
merged 7 commits into from
Nov 14, 2022
Merged

chore: windows winget package auto update on every release #4761

merged 7 commits into from
Nov 14, 2022

Conversation

matifali
Copy link
Member

@matifali matifali commented Oct 26, 2022

Added winget publish action on release.
Linked to #3714
@deansheather

Added `winget` update action on release
@matifali
Copy link
Member Author

Not sure how to test it. Will it submit the package in my name or the coder

@deansheather deansheather self-requested a review October 26, 2022 11:43
A GitHub Personal Access token is required to submit packages to winget community repo.

https://github.com/microsoft/winget-create/blob/main/doc/token.md

Please create a token as shown here and store it as a secret in `GITHUB_PAT`
@matifali matifali marked this pull request as ready for review October 27, 2022 10:34
@matifali
Copy link
Member Author

To push an update, we first need to create a package for the first time that is interactive and manual.
I am not sure if it has to be created using Coder Inc. GitHub or if I can do it from my account.
Meanwhile, I have created a PR here also,
microsoft/winget-pkgs#86416
and tried to fill in all the required metadata from coder.com/

@matifali
Copy link
Member Author

matifali commented Oct 27, 2022

Also,
A GitHub Personal Access token is required to submit packages to winget community repo.

https://github.com/microsoft/winget-create/blob/main/doc/token.md

Please create a token as shown here and store it as a secret in GITHUB_PAT

Or maybe the existing GITHUB_TOKEN be used. It's a test.
@deansheather

@matifali
Copy link
Member Author

matifali commented Oct 28, 2022

To push an update, we first need to create a package for the first time that is interactive and manual.
I am unsure if it has to be created using Coder Inc. GitHub or if I can do it from my account.
Meanwhile, I have created a PR here also,
microsoft/winget-pkgs#86416
and tried to fill in all the required metadata from coder.com/

My PR was closed as a duplicate of microsoft/winget-pkgs#86238, I did not check that you have already submitted a PR.

@deansheather
Copy link
Member

I'll do a review pass of this PR on Monday and get it merged for you. We'll sort out the bounty payout post-merge cc @ghuntley

@deansheather
Copy link
Member

I updated your PR to use GH CLI instead of pinging the API directly (to avoid potential ratelimits), as well as updated it to comment on the PR pinging me so microsoft maintainers can get in contact with me if something's wrong.

I also discovered that the file version I was inserting into the installer binary was incorrect so I fixed that as well.

Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I contributed so I'll get Colin to review it

@matifali
Copy link
Member Author

matifali commented Nov 1, 2022

I updated your PR to use GH CLI instead of pinging the API directly (to avoid potential ratelimits), as well as updated it to comment on the PR pinging me so microsoft maintainers can get in contact with me if something's wrong.

I also discovered that the file version I was inserting into the installer binary was incorrect so I fixed that as well.

Yes, it looks like a better approach. Yes, the installer version had the 4th section as the release date.
Also, to test this in production it should be merged before the next release.

@deansheather deansheather enabled auto-merge (squash) November 2, 2022 11:58
@ghuntley
Copy link
Contributor

ghuntley commented Nov 8, 2022

Thanks for sending in the pull-request @matifali I'm going to have a look/review after lunch. A quick note to say haven't forgotten!

@matifali matifali changed the title Create submit-windows-packages.yml chore: windows winget package auto update on every release Nov 8, 2022
@deansheather deansheather merged commit 990be63 into coder:main Nov 14, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2022
@matifali matifali deleted the winget-release branch November 14, 2022 13:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants