Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use correct empty uuids #4917

Merged
merged 1 commit into from Nov 6, 2022
Merged

fix: use correct empty uuids #4917

merged 1 commit into from Nov 6, 2022

Conversation

coadler
Copy link
Member

@coadler coadler commented Nov 6, 2022

No description provided.

@coadler coadler self-assigned this Nov 6, 2022
kylecarbs
kylecarbs approved these changes Nov 6, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What harm was this causin?

@coadler
Copy link
Member Author

coadler commented Nov 6, 2022

Since it was properly casting to a uuid i don't think it was causing any problems. It was just weird to have them inconsistently used.

@coadler coadler merged commit 65ffa20 into main Nov 6, 2022
@coadler coadler deleted the colin/fix-null-uuids branch November 6, 2022 22:49
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@coadler @kylecarbs