Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: 1. fix closing ) on projector examples 2.update jupyter section… #4920

Merged
merged 1 commit into from Nov 7, 2022
Merged

docs: 1. fix closing ) on projector examples 2.update jupyter section… #4920

merged 1 commit into from Nov 7, 2022

Conversation

sharkymark
Copy link
Contributor

… for using subdomain=true and removal of owner and workspace baseURL

This is PR:

  1. updates the Jupyter example to reflect using subdomain=true in the coder_app
  2. removal of the baseURL flag in launching Jupyter
  3. removal of the owner and workspace names from the base URL and coder_app
  4. added a missing closing ) in a projector repo link
  5. added a new jupyter screenshot

jupyter-on-docker

@sharkymark
docs: 1. fix closing ) on projector examples 2.update jupyter section…
6917ee7 
… for slug config and removal of owner and workspace baseURL
@ammario ammario removed their request for review November 6, 2022 21:42
@bpmct bpmct merged commit 1545979 into main Nov 7, 2022
@bpmct bpmct deleted the docs-jupyter branch November 7, 2022 18:41
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpmct bpmct bpmct approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sharkymark @bpmct