Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove workspace schedule banner #4932

Merged
merged 1 commit into from
Nov 8, 2022
Merged

refactor: Remove workspace schedule banner #4932

merged 1 commit into from
Nov 8, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Close #4919

It's unnecessary now that we have activity-based extension.

@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner November 7, 2022 16:51
@BrunoQuaresma BrunoQuaresma self-assigned this Nov 7, 2022
@BrunoQuaresma BrunoQuaresma requested review from presleyp and removed request for a team November 7, 2022 16:51
@BrunoQuaresma
Copy link
Collaborator Author

@presleyp I see we have a workspaceScheduleBannerXService but it does more than control the banner. Is it ok if we rename it to workspaceScheduleXService instead?

@presleyp
Copy link
Contributor

presleyp commented Nov 7, 2022

@presleyp I see we have a workspaceScheduleBannerXService but it does more than control the banner. Is it ok if we rename it to workspaceScheduleXService instead?

Yes, thanks!

@BrunoQuaresma
Copy link
Collaborator Author

@presleyp I see we already have a workspaceScheduleXService. I'm merging this for now and I will investigate that after.

@BrunoQuaresma BrunoQuaresma merged commit 2af698c into main Nov 8, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/remove-shutdown-warning branch November 8, 2022 13:05
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@presleyp presleyp Awaiting requested review from presleyp presleyp was automatically assigned from coder/ts

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove workspace about to shut down system notification
3 participants
@BrunoQuaresma @presleyp @kylecarbs