feat: Add external provisioner daemons #4935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
force-pushed
the
provisionerdaemons
branch
from
1436324
to
29f6f49
Compare
coadler
approved these changes
Nov 16, 2022
coderd/database/migrations/000077_provisioner_daemon_tags.down.sql
Outdated
Show resolved
Hide resolved
kylecarbs
force-pushed
the
provisionerdaemons
branch
from
f02e82d
to
2fa16e4
Compare
kylecarbs
force-pushed
the
provisionerdaemons
branch
from
2fa16e4
to
ea94e1b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the concept of tags to provisioner daemons.
When creating a template or pushing a new version,
--provisioner-tagis now a command-line option. This allows you to target provisioners with the matching set of tags.coder provisionerd start --tag key=valuelaunches a new provisioner daemon.scope=useris a special tag that will auto-insert theowner=<user-id>tag when the user initializes build operations for their resources. This solves #909 by allowing users to run a daemon, and template admins can target them.This feature lacks polish right now (notably, the UI will show a "Pending" state if a daemon isn't matching the specified tags), but that seems fine while we initially test. This doesn't make any irreversible changes, so it should be good to merge.