feat: make trace provider in loadtest, add tracing to sdk #4939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coadler
approved these changes
Nov 7, 2022
| ctx, span := tracing.StartSpan(ctx) | ||
| defer span.End() | ||
|
|
||
| conn, err := c.DialContextTCP(ctx, netip.AddrPortFrom(TailnetIP, uint16(TailnetReconnectingPTYPort))) |
There was a problem hiding this comment.
Might be nice to capture the errors in the span too.
There was a problem hiding this comment.
There are a lot of errors across the codebase we would have to catch, so it's kinda weird to only do it here. It'd be nice if we could hook into all returned error values in Golang but I don't think that's possible without writing and enforcing a wrapper for errors instead of xerrors.Errorf
|
Propagation works properly now. |
coadler
approved these changes
Nov 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coder loadtestusing the given configuration flagscodersdk.(*Client).Request(using parent function name) and select other methods in codersdk*Clientthrough an option) and coderd using the standardizedtraceparentheaderUntested whether the tracing propagation works, I'll need to setup a test env for it