Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use app IDs instead of the display name to report health #4944

Merged
merged 2 commits into from Nov 7, 2022

Conversation

kylecarbs
Copy link
Member

All applications without display names were reporting broken health.

@kylecarbs kylecarbs self-assigned this Nov 7, 2022
@ammario ammario linked an issue Nov 7, 2022 that may be closed by this pull request
@kylecarbs kylecarbs enabled auto-merge (squash) November 7, 2022 23:10
All applications without display names were reporting broken health.
agent/apphealth.go Outdated Show resolved Hide resolved
Co-authored-by: Dean Sheather <dean@deansheather.com>
@kylecarbs kylecarbs changed the title fix: Use app slugs instead of the display name to report health fix: Use app IDs instead of the display name to report health Nov 7, 2022
@kylecarbs kylecarbs merged commit 165b6fb into main Nov 7, 2022
@kylecarbs kylecarbs deleted the apphealth branch November 7, 2022 23:35
@github-actions github-actions bot locked and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Health check failure is confusing
2 participants