Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Off-by-one created after notification for provisioner logs #4949

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Nov 8, 2022

This seemed like the obvious case, but I have yet to verify if it actually fixes the bug.

Maybe fixes #4948

@mafredri mafredri self-assigned this Nov 8, 2022
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, good find!

@mafredri mafredri merged commit d1c82f6 into main Nov 8, 2022
@mafredri mafredri deleted the mafredri/build-log-queue-fix branch November 8, 2022 15:56
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not all build logs are streamed to CLI after v0.12.5 update (e.g. when running coder start or coder update)
2 participants