Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pprof for coder agent is always on #4951

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Nov 8, 2022

Fixes: #2081

This PR enables the pprof endpoint for the coder agent by default. It may result in port conflicts if there is another application listening on that port (127.0.0.1:6060).

@mtojek mtojek self-assigned this Nov 8, 2022
@mtojek mtojek changed the title feat: pprof is always on feat: pprof for coder agent is always on Nov 8, 2022
@mtojek mtojek marked this pull request as ready for review November 8, 2022 13:22
@mtojek mtojek requested a review from a team November 8, 2022 13:22
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

😍

@mtojek mtojek merged commit bf4a6fb into coder:main Nov 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2022
@kylecarbs
Copy link
Member

Is port 6060 used frequently for development by any language? I'd hate to modify someone's workflow if they adopt Coder.

I also believe our port forward dialog will pick this up and display it in the UI, which we should disable. It might be worth considering only doing this behavior on Windows, but that's also kinda jank.

@mtojek
Copy link
Member Author

mtojek commented Nov 8, 2022

Is port 6060 used frequently for development by any language? I'd hate to modify someone's workflow if they adopt Coder.

Looking at the speedguide stats, it seems to be mostly related to pprof debugging, so it should be safe.

It might be worth considering only doing this behavior on Windows, but that's also kinda jank.

I think that it's worth keeping the consistent behavior, otherwise, we may confuse people working on different OS platforms. I'm pretty sure that users will survive with 1 more reserved port.

I also believe our port forward dialog will pick this up and display it in the UI, which we should disable.

I understand that we wouldn't like to expose the 6060 in the port-forward mode, am I correct? I'm wondering if it isn't a feature to allow for accessing it, even for customer debugging purposes (heap dump?)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for enabling pprof endpoints in coder agent on Windows during runtime
3 participants