chore: Find source files once in Makefile targets #4968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
approved these changes
Nov 9, 2022
Makefile
Outdated
| # Source files used for make targets, evaluated on use. | ||
| GO_SRC_FILES = $(shell find . -not -path './vendor/*' -type f -name '*.go') | ||
| # All the shell files in the repo, excluding ignored files. | ||
| SHELL_SRC_FILES = $(shell shfmt -f . | grep -v "\.coderv2/") |
There was a problem hiding this comment.
Since we don't have shfmt installed in every single CI run now is a good opportunity to change this to a find instead to avoid "shfmt: command not found" messages in CI.
There was a problem hiding this comment.
I like shfmt -f because it doesn't rely on file extension, can find scripts without as well. But on the flip side, we don't need that feature and if it simplifies CI then why not 👍🏻.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small optimizations to the Makefile, like finding source files once.
Also filters out
.coderv2/postgreswhich contains shell files.