Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve docker example first user experience #4972

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Nov 9, 2022

Noticed we use an image build in the base docker image these days, however, it did not add any users accounts. This is my take on fixing it.

The base ubuntu image lands the user as root, but the terraform tempalte
expected /home/coder to be used. This change adds a user with the same
name as the Coder users username and allows them to sudo.

The base ubuntu image lands the user as root, but the terraform tempalte
expected /home/coder to be used. This change adds a user with the same
name as the Coder users username and allows them to sudo.
@mafredri mafredri self-assigned this Nov 9, 2022
@mafredri mafredri requested a review from a team November 9, 2022 14:29
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only nit-picks

examples/templates/docker/build/Dockerfile Outdated Show resolved Hide resolved
examples/templates/docker/build/Dockerfile Show resolved Hide resolved
@mafredri mafredri merged commit 570a1ff into main Nov 10, 2022
@mafredri mafredri deleted the mafredri/docker-example-user branch November 10, 2022 10:55
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants