Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Display warning on agent connection timeout #4983

Merged
merged 3 commits into from
Nov 9, 2022
Merged

feat: Display warning on agent connection timeout #4983

merged 3 commits into from
Nov 9, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Screen Shot 2022-11-09 at 14 36 20

@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner November 9, 2022 17:38
@BrunoQuaresma BrunoQuaresma self-assigned this Nov 9, 2022
@BrunoQuaresma BrunoQuaresma requested review from presleyp and removed request for a team November 9, 2022 17:38
mafredri
mafredri approved these changes Nov 9, 2022
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great functionality wise 👍🏻. The exclamation icon looks a bit weird in my eyes but I don't have a suggestion to make it better. 😄

I did notice that I had to manually refresh the workspace page for the agent status to update. But it looks like my session didn't have a SSE session open so maybe that's why. Not sure why it isn't working.

site/src/components/Resources/AgentStatus.tsx Show resolved Hide resolved
site/src/i18n/en/agent.json Outdated Show resolved Hide resolved
site/src/i18n/en/agent.json Outdated Show resolved Hide resolved
BrunoQuaresma and others added 2 commits November 9, 2022 18:44
@BrunoQuaresma
Add README section id
d7fe799
@BrunoQuaresma @mafredri
Apply suggestions from code review
47cfc10 
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
@BrunoQuaresma
Copy link
Collaborator Author

@mafredri

Looks great functionality wise 👍🏻. The exclamation icon looks a bit weird in my eyes but I don't have a suggestion to make it better. 😄

Hm... maybe it is the color or the icon itself?

I did notice that I had to manually refresh the workspace page for the agent status to update. But it looks like my session didn't have a SSE session open so maybe that's why. Not sure why it isn't working.

Probably. Since the status is updated automatically.

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) November 9, 2022 20:31
@BrunoQuaresma BrunoQuaresma merged commit d225f2c into main Nov 9, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/show-warning-on-timeout branch November 9, 2022 20:40
@github-actions github-actions bot locked and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mafredri mafredri mafredri approved these changes

@presleyp presleyp presleyp approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BrunoQuaresma @mafredri @presleyp