Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template delete button/kira pilot #4992

Merged
merged 6 commits into from
Nov 10, 2022
Merged

Template delete button/kira pilot #4992

merged 6 commits into from
Nov 10, 2022

Conversation

Kira-Pilot
Copy link
Member

@Kira-Pilot Kira-Pilot commented Nov 9, 2022 •
edited

resolves #4980

Screen Shot 2022-11-10 at 10 02 23 AM

Kapture 2022-11-10 at 10 00 33

@Kira-Pilot Kira-Pilot requested a review from a team as a code owner November 9, 2022 22:47
@Kira-Pilot Kira-Pilot requested review from jsjoeio and removed request for a team November 9, 2022 22:47
Kira-Pilot
Kira-Pilot commented Nov 10, 2022
View reviewed changes
site/src/pages/TemplateSettingsPage/TemplateSettingsForm.tsx
<Typography variant="subtitle2">
{Language.ttlHelperText(form.values.default_ttl_ms)}
</Typography>
<span>{Language.ttlHelperText(form.values.default_ttl_ms)}</span>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this because I thought it was too big. Now it matches the other helper text in the form.

jsjoeio
jsjoeio approved these changes Nov 10, 2022
View reviewed changes
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

bikeshed: I do think we should refactor this UX though. If we ask someone to type in the name of something, we should show it to them in that model. GitHub and Vercel do this. See example:

image

@Kira-Pilot
Copy link
Member Author

@jsjoeio thanks for the review!

If we ask someone to type in the name of something, we should show it to them in that model.

Just want to make sure I understand: we do show the name of the template as the user begins typing, but you're saying we should show it in the modal description to be clearer. Is that right?
Screen Shot 2022-11-10 at 10 32 13 AM

@Kira-Pilot Kira-Pilot merged commit 1c9677d into main Nov 10, 2022
@Kira-Pilot Kira-Pilot deleted the template-delete-button/kira-pilot branch November 10, 2022 15:41
@github-actions github-actions bot locked and limited conversation to collaborators Nov 10, 2022
@jsjoeio
Copy link
Contributor

jsjoeio commented Nov 10, 2022

Just want to make sure I understand: we do show the name of the template as the user begins typing, but you're saying we should show it in the modal description to be clearer. Is that right?

Exactly!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jsjoeio jsjoeio jsjoeio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Delete Template" action is in an odd place right now
2 participants
@Kira-Pilot @jsjoeio