fix: Misc improvements to scripts/develop.sh
#4995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
force-pushed
the
mafredri/develop-script-improvements
branch
from
1256ec4
to
ec48b37
Compare
* Use new `/healthz` endpoint for checking API liveness * Improved credential handling/retrying in failure scenarios * Separate site (`vite`) logs with prefix and date, additionally this method also disables the `vite` clearing of the screen * Show all interfaces coder API is listening on (due to `0.0.0.0`)
mafredri
force-pushed
the
mafredri/develop-script-improvements
branch
from
ec48b37
to
5fd8657
Compare
mtojek
reviewed
Nov 10, 2022
mafredri
force-pushed
the
mafredri/develop-script-improvements
branch
from
1c895d3
to
3e438e7
Compare
mafredri
force-pushed
the
mafredri/develop-script-improvements
branch
from
de51030
to
7f1f744
Compare
|
Ok, made one pretty big additional change in Interrupts, failures and cleanup should be handled better now. I often ran into issues with PostgreSQL or node (vite) still running after the script has exited. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/healthzendpoint for checking API livenessvite) logs with prefix and date, additionally thismethod also disables the
viteclearing of the screen0.0.0.0)Edit: