fix: Fix ssh message/spinner in VSCode integrated terminal #5000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The messages never show up in VSCode integrated terminal due to the defer `fmt.Fprintf`. There could be a race in VSCode in handling the terminal codes but ultimately, we can simplify our logic by just stopping the spinner for the duration of the update.
kylecarbs
approved these changes
Nov 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The messages never show up in VSCode integrated terminal due to the
defer
fmt.Fprintf. There could be a race in VSCode in handling theterminal codes but ultimately, we can simplify our logic by just
stopping the spinner for the duration of the update.