feat: add count to get users endpoint #5016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@coadler would this work? I will go further with this if there aren't any immediate concern. |
coadler
reviewed
Nov 10, 2022
f0ssel
changed the title
presleyp
reviewed
Nov 14, 2022
presleyp
reviewed
Nov 14, 2022
presleyp
reviewed
Nov 14, 2022
presleyp
approved these changes
Nov 14, 2022
coadler
approved these changes
Nov 14, 2022
Comment on lines
+216
to
+224
| // GetUsers does not return ErrNoRows because it uses a window function to get the count. | ||
| // So we need to check if the userRows is empty and return an empty array if so. | ||
| if len(userRows) == 0 { | ||
| httpapi.Write(ctx, rw, http.StatusOK, codersdk.GetUsersResponse{ | ||
| Users: []codersdk.User{}, | ||
| Count: 0, | ||
| }) | ||
| return | ||
| } |
There was a problem hiding this comment.
I don't think it ever could return that error anyways since it returns an array, and only :one queries will error. I think this simplifies the code below though, which is nice.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this changes:
GET /api/v2/users/countendpoint and removes usage from the dashboardcountfield to theGET /api/v2/usersresponseThis will ideally be the template for paginated queries moving forward.