Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(site): configure global fonts #503

Merged
merged 3 commits into from
Mar 22, 2022
Merged

Conversation

greyscaled
Copy link
Contributor

Summary:

Installs fira code and Inter

Impact:

A more pleasant dashboard experience in v2 that matches our prefer font
families from v1

Summary:

Installs fira code and Inter

Impact:

A more pleasant dashboard experience in v2 that matches our prefer font
families from v1
@greyscaled greyscaled self-assigned this Mar 20, 2022
@greyscaled greyscaled requested a review from a team as a code owner March 20, 2022 20:26
@greyscaled greyscaled enabled auto-merge (squash) March 20, 2022 20:26
@codecov
Copy link

codecov bot commented Mar 20, 2022

Codecov Report

Merging #503 (2985b84) into main (43d433c) will decrease coverage by 0.15%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
- Coverage   68.10%   67.95%   -0.16%     
==========================================
  Files         164      165       +1     
  Lines        9309     9315       +6     
  Branches       85       85              
==========================================
- Hits         6340     6330      -10     
- Misses       2345     2358      +13     
- Partials      624      627       +3     
Flag Coverage Δ
unittest-go-macos-latest 62.41% <ø> (-0.07%) ⬇️
unittest-go-ubuntu-latest 67.56% <ø> (-0.14%) ⬇️
unittest-go-windows-2022 62.29% <ø> (+0.26%) ⬆️
unittest-js 63.19% <0.00%> (-0.45%) ⬇️
Impacted Files Coverage Δ
site/src/app.tsx 0.00% <0.00%> (ø)
site/src/theme/global-fonts.ts 0.00% <0.00%> (ø)
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
peerbroker/dial.go 75.43% <0.00%> (-7.02%) ⬇️
provisionerd/provisionerd.go 77.20% <0.00%> (-2.21%) ⬇️
peerbroker/proxy.go 57.55% <0.00%> (-0.59%) ⬇️
coderd/provisionerdaemons.go 57.60% <0.00%> (-0.55%) ⬇️
peer/conn.go 79.53% <0.00%> (+1.53%) ⬆️
peer/channel.go 85.96% <0.00%> (+2.33%) ⬆️
provisionersdk/transport.go 85.10% <0.00%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43d433c...2985b84. Read the comment docs.

Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@greyscaled
Copy link
Contributor Author

Looks like there are missing rules in our webpack build, I'll fix this.

@greyscaled greyscaled merged commit 2818b3c into main Mar 22, 2022
@greyscaled greyscaled deleted the vapurrmaid/global-fonts branch March 22, 2022 17:57
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants