Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add version page #5071

Merged
merged 15 commits into from
Nov 15, 2022
Merged

feat: Add version page #5071

merged 15 commits into from
Nov 15, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

Screen Shot 2022-11-14 at 13 52 32

Ps: Adding tests in the next commit - I forgot 🤦

@BrunoQuaresma BrunoQuaresma self-assigned this Nov 14, 2022
@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner November 14, 2022 16:53
@BrunoQuaresma BrunoQuaresma requested review from presleyp and removed request for a team November 14, 2022 16:53
@BrunoQuaresma BrunoQuaresma requested a review from a team November 14, 2022 18:41
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With tests and error handling, should be good!

@Emyrk
Copy link
Member

Emyrk commented Nov 14, 2022

I assume all users cannot read the tf file though right?

@BrunoQuaresma
Copy link
Collaborator Author

I assume all users cannot read the tf file though right?

Yes, I think so. So probably we want to protect the files route, right?

@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) November 15, 2022 16:21
@BrunoQuaresma BrunoQuaresma merged commit f262fb4 into main Nov 15, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/add-template-version-page branch November 15, 2022 16:24
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants