Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: refactor workspaces query to use window function #5079

Merged
merged 5 commits into from
Nov 16, 2022
Merged

chore: refactor workspaces query to use window function #5079

merged 5 commits into from
Nov 16, 2022

Conversation

presleyp
Copy link
Contributor

Use window function to get count in the same query as workspaces.

@presleyp presleyp marked this pull request as ready for review November 15, 2022 15:35
f0ssel
f0ssel reviewed Nov 15, 2022
View reviewed changes
Copy link
Contributor

@f0ssel f0ssel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, glad it's this simple.

Could we also just go ahead and remove the route and front end usage of the count endpoint in this PR?

@presleyp
Copy link
Contributor Author

Looks great, glad it's this simple.

Could we also just go ahead and remove the route and front end usage of the count endpoint in this PR?

That's mostly done already but I see some count cruft left in the machine that I'll take out.

@presleyp presleyp requested a review from a team as a code owner November 16, 2022 14:58
@presleyp presleyp requested review from code-asher and removed request for a team November 16, 2022 14:58
Kira-Pilot
Kira-Pilot reviewed Nov 16, 2022
View reviewed changes
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FE ✅

BrunoQuaresma
BrunoQuaresma approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@presleyp presleyp merged commit e6ead7d into main Nov 16, 2022
@presleyp presleyp deleted the ws-window/presleyp branch November 16, 2022 15:16
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@f0ssel f0ssel f0ssel left review comments

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

@kylecarbs kylecarbs Awaiting requested review from kylecarbs

@code-asher code-asher Awaiting requested review from code-asher code-asher was automatically assigned from coder/ts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@presleyp @BrunoQuaresma @Kira-Pilot @f0ssel