feat: show template.display_name on Workspace pages #5082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtojek
changed the title
mtojek
requested review from
code-asher,
a team and
presleyp
and removed request for
a team,
code-asher and
presleyp
BrunoQuaresma
approved these changes
Nov 16, 2022
| it("renders the template display name", async () => { | ||
| await renderWorkspacePage() | ||
| await screen.findByText(MockWorkspace.template_display_name) | ||
| }) |
There was a problem hiding this comment.
In the FE, we use Storybook for visual tests and "integration tests"(the ones run by Jest) only for testing actions. So I think we can remove this.
There was a problem hiding this comment.
Removed, thanks for the suggestion!
| <TableCellDataPrimary> | ||
| {workspace.template_display_name.length > 0 | ||
| ? workspace.template_display_name | ||
| : workspace.template_name} |
There was a problem hiding this comment.
Maybe we could have a util function on utils/workspace called getWorkspaceDisplayName(workspace: Workspace): string but it is your call.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3321
This PR modifies the Workspaces API to expose
template.display_name. The property is consumed by Workspace pages.