Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove pagination widget when filter is invalid #5095

Merged
merged 2 commits into from
Nov 16, 2022
Merged

fix: remove pagination widget when filter is invalid #5095

merged 2 commits into from
Nov 16, 2022

Conversation

presleyp
Copy link
Contributor

Fixes #5092

My XState plugin changed the formatting so the diff looks big but all I actually did was:

  • remove the getUsersCountError because count isn't a separate endpoint anymore so it will never be assigned to
  • clear count in clearUsers (to mirror how assignUsers assigns both users and count)

Now that count is undefined after an invalid filter, the pagination widget correctly doesn't show.

@presleyp presleyp requested a review from a team as a code owner November 15, 2022 17:32
@presleyp presleyp requested review from BrunoQuaresma and removed request for a team November 15, 2022 17:32
BrunoQuaresma
BrunoQuaresma approved these changes Nov 16, 2022
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@presleyp presleyp merged commit 560d3c9 into main Nov 16, 2022
@presleyp presleyp deleted the invalid-filter/presleyp branch November 16, 2022 14:55
@github-actions github-actions bot locked and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pagination: pager shows multiple pages when filter returns no results
2 participants
@presleyp @BrunoQuaresma