fix: Refactor tailnet conn AwaitReachable to allow for pings >1s RTT #5096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially I was just going to remove the 1s ping timeout to allow for connections with RTT >1s, however, then we'd run the risk of running an infinite number of goroutines if a network is down.
Opted to add back the timeout (increased to 5 minutes) with exponential backoff. This seems like a safe timeout to use, any connection that takes longer is quite likely unusable.
Follow up to: https://github.com/coder/coder/pull/5043/files#r1021908754