Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly copy binaries in make install #517

Merged
merged 1 commit into from
Mar 22, 2022
Merged

Conversation

coadler
Copy link
Member

@coadler coadler commented Mar 22, 2022

Since it copied to a nested directory, it's very confusing if you
already had a coder binary in your ~/go/bin, since it would always
prefer the coder in the higher directory.

Since it copied to a nested directory, it's very confusing if you
already had a `coder` binary in your `~/go/bin`, since it would always
prefer the `coder` in the higher directory.
@coadler coadler self-assigned this Mar 22, 2022
@coadler coadler requested a review from kylecarbs March 22, 2022 01:04
@coadler coadler enabled auto-merge (squash) March 22, 2022 01:08
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #517 (3b11f0b) into main (b55a67a) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #517      +/-   ##
==========================================
- Coverage   68.11%   68.10%   -0.02%     
==========================================
  Files         164      161       -3     
  Lines        9309     9129     -180     
  Branches       85       85              
==========================================
- Hits         6341     6217     -124     
+ Misses       2344     2305      -39     
+ Partials      624      607      -17     
Flag Coverage Δ
unittest-go-macos-latest 62.62% <ø> (+0.06%) ⬆️
unittest-go-ubuntu-latest 67.44% <ø> (-0.22%) ⬇️
unittest-go-windows-2022 ?
unittest-js 63.63% <ø> (ø)
Impacted Files Coverage Δ
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
pty/ptytest/ptytest.go 94.44% <0.00%> (-5.56%) ⬇️
provisionerd/provisionerd.go 77.57% <0.00%> (-1.11%) ⬇️
peer/conn.go 80.56% <0.00%> (-0.77%) ⬇️
coderd/provisionerdaemons.go 57.06% <0.00%> (-0.55%) ⬇️
agent/usershell/usershell_windows.go
pty/start_windows.go
pty/pty_windows.go
provisionersdk/transport.go 85.10% <0.00%> (+6.38%) ⬆️
peerbroker/dial.go 82.45% <0.00%> (+7.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b55a67a...3b11f0b. Read the comment docs.

@coadler coadler merged commit 01ab487 into main Mar 22, 2022
@coadler coadler deleted the colin/fix-make-install branch March 22, 2022 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants