Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable files.insertFinalNewline in vscode #518

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

coadler
Copy link
Member

@coadler coadler commented Mar 22, 2022

Ensures there's always a newline at the end of files. They seem to be
randomly missing, which cause weird diffs.

Ensures there's always a newline at the end of files. They seem to be
randomly missing, which cause weird diffs.
@coadler coadler self-assigned this Mar 22, 2022
@coadler coadler requested a review from kylecarbs March 22, 2022 01:27
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #518 (e763fd0) into main (b55a67a) will decrease coverage by 0.16%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
- Coverage   68.11%   67.95%   -0.17%     
==========================================
  Files         164      164              
  Lines        9309     9309              
  Branches       85       85              
==========================================
- Hits         6341     6326      -15     
- Misses       2344     2354      +10     
- Partials      624      629       +5     
Flag Coverage Δ
unittest-go-macos-latest 62.63% <ø> (+0.07%) ⬆️
unittest-go-ubuntu-latest 67.37% <ø> (-0.30%) ⬇️
unittest-go-windows-2022 62.02% <ø> (-0.17%) ⬇️
unittest-js 63.63% <ø> (ø)
Impacted Files Coverage Δ
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
peerbroker/listen.go 81.35% <0.00%> (-2.55%) ⬇️
peerbroker/proxy.go 57.55% <0.00%> (-1.75%) ⬇️
provisionerd/provisionerd.go 77.20% <0.00%> (-1.48%) ⬇️
coderd/provisionerdaemons.go 57.06% <0.00%> (-0.55%) ⬇️
peer/conn.go 80.81% <0.00%> (-0.52%) ⬇️
peer/channel.go 85.96% <0.00%> (+2.33%) ⬆️
provisionersdk/transport.go 85.10% <0.00%> (+6.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b55a67a...e763fd0. Read the comment docs.

@coadler coadler merged commit 3b29b15 into main Mar 22, 2022
@coadler coadler deleted the colin/vscode-final-newline branch March 22, 2022 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants