Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dogfood): install nix package manager #5308

Merged
merged 19 commits into from
Jan 26, 2023
Merged

feat(dogfood): install nix package manager #5308

merged 19 commits into from
Jan 26, 2023

Conversation

ghuntley
Copy link
Contributor

@ghuntley ghuntley commented Dec 6, 2022

Internal discussion thread.

dogfood/Dockerfile Outdated Show resolved Hide resolved
@mtojek mtojek self-requested a review December 6, 2022 13:21
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please share a bit more context about this change and fix the link in the description?

@ghuntley
Copy link
Contributor Author

ghuntley commented Dec 6, 2022

Could you please share a bit more context about this change and fix the link in the description?

Apologies - I linked to the wrong link. See conversation at #devrandom. I use nix personally and not having access to the nix package manager is causing self-papercuts. Setting sandbox = false is key to enable installation.

CleanShot 2022-12-06 at 23 54 51@2x

dogfood/Dockerfile Outdated Show resolved Hide resolved
dogfood/Dockerfile Outdated Show resolved Hide resolved
dogfood/Dockerfile Outdated Show resolved Hide resolved
dogfood/Dockerfile Outdated Show resolved Hide resolved
dogfood/Dockerfile Outdated Show resolved Hide resolved
dogfood/Dockerfile Outdated Show resolved Hide resolved
dogfood/Dockerfile Outdated Show resolved Hide resolved
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for addressing the comments! Feel free to merge if other approvers are 👍 .

dogfood/main.tf Outdated Show resolved Hide resolved
dogfood/Dockerfile Outdated Show resolved Hide resolved
dogfood/Dockerfile Outdated Show resolved Hide resolved
@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Dec 20, 2022
@ghuntley
Copy link
Contributor Author

Thanks @mafredri and @mtojek for your eyeballs and guidance here.

Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, looking pretty clean! 👍🏻

dogfood/main.tf Outdated
Comment on lines 61 to 62
echo '. /home/coder/.nix-profile/etc/profile.d/nix.sh' >> /home/coder/.bashrc
bash /opt/nix/install --no-daemon
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test this, but imagine it should be a bit more portable and avoid adding the entry every startup.

Suggested change
echo '. /home/coder/.nix-profile/etc/profile.d/nix.sh' >> /home/coder/.bashrc
bash /opt/nix/install --no-daemon
bash /opt/nix/install --no-daemon
if ! grep -q '. ~/.nix-profile/etc/profile.d/nix.sh' ~/.bashrc; then
echo '. ~/.nix-profile/etc/profile.d/nix.sh' >> ~/.bashrc
fi

Ultimately, we might want to add this logic into /etc/profile.d/nix.sh and /etc/zsh/zprofile (via Dockerfile) so that it's available in all shells. But that can be done in a separate PR.

@github-actions github-actions bot removed the stale This issue is like stale bread. label Dec 23, 2022
@github-actions
Copy link

github-actions bot commented Jan 6, 2023

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Jan 6, 2023
@mafredri mafredri removed the stale This issue is like stale bread. label Jan 18, 2023
@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Jan 26, 2023
@mafredri mafredri merged commit bfc8a10 into main Jan 26, 2023
@mafredri mafredri deleted the ghuntley-patch-2 branch January 26, 2023 14:39
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2023
@mafredri mafredri restored the ghuntley-patch-2 branch January 26, 2023 15:36
@matifali matifali deleted the ghuntley-patch-2 branch June 16, 2023 02:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale This issue is like stale bread.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants