Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Improve coverage by uploading PostgreSQL tests #532

Merged
merged 1 commit into from
Mar 23, 2022
Merged

fix: Improve coverage by uploading PostgreSQL tests #532

merged 1 commit into from
Mar 23, 2022

Conversation

kylecarbs
Copy link
Member

This also adds a test for workspace creation via the CLI.

This also adds a test for workspace creation via the CLI.
@kylecarbs kylecarbs requested a review from coadler March 22, 2022 23:09
@kylecarbs kylecarbs self-assigned this Mar 22, 2022
@codecov
Copy link

codecov bot commented Mar 22, 2022

Codecov Report

Merging #532 (8528e33) into main (26d24f4) will increase coverage by 2.53%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #532      +/-   ##
==========================================
+ Coverage   60.35%   62.88%   +2.53%     
==========================================
  Files         191      190       -1     
  Lines       10864    10802      -62     
  Branches       85       85              
==========================================
+ Hits         6557     6793     +236     
+ Misses       3587     3270     -317     
- Partials      720      739      +19     
Flag Coverage Δ
unittest-go- 61.89% <ø> (?)
unittest-go-macos-latest 57.43% <ø> (+1.31%) ⬆️
unittest-go-ubuntu-latest 60.85% <ø> (+1.02%) ⬆️
unittest-go-windows-2022 56.85% <ø> (+0.94%) ⬆️
unittest-js 63.19% <ø> (ø)
Impacted Files Coverage Δ
provisioner/echo/serve.go 54.40% <0.00%> (-2.40%) ⬇️
coderd/tunnel/tunnel.go
coderd/projects.go 62.90% <0.00%> (+1.61%) ⬆️
peer/conn.go 78.17% <0.00%> (+2.03%) ⬆️
provisionerd/provisionerd.go 80.00% <0.00%> (+3.11%) ⬆️
coderd/provisionerdaemons.go 62.18% <0.00%> (+3.57%) ⬆️
codersdk/projectversions.go 65.51% <0.00%> (+5.17%) ⬆️
provisionersdk/transport.go 85.10% <0.00%> (+6.38%) ⬆️
coderd/projectversions.go 59.85% <0.00%> (+8.45%) ⬆️
coderd/coderdtest/coderdtest.go 98.88% <0.00%> (+10.00%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 26d24f4...8528e33. Read the comment docs.

@kylecarbs kylecarbs enabled auto-merge (squash) March 22, 2022 23:14
@kylecarbs kylecarbs merged commit d665263 into main Mar 23, 2022
@kylecarbs kylecarbs deleted the cov branch March 23, 2022 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants