fix: Parse prompt input JSON using object or array chars #538
Conversation
Codecov Report
@@ Coverage Diff @@
## main #538 +/- ##
==========================================
+ Coverage 62.65% 63.08% +0.43%
==========================================
Files 194 194
Lines 10827 10837 +10
Branches 85 85
==========================================
+ Hits 6784 6837 +53
+ Misses 3302 3269 -33
+ Partials 741 731 -10
Continue to review full report at Codecov.
|
kylecarbs
force-pushed
the
multilineprompt
branch
from
944864f
to
f25af04
Compare
Fixes #492. There is no more single-quote parsing, and instead we use a JSON decoder for multiline values. This is a much better UX!
kylecarbs
force-pushed
the
multilineprompt
branch
from
f25af04
to
60ad570
Compare
| pipeReader, pipeWriter := io.Pipe() | ||
| defer pipeWriter.Close() | ||
| defer pipeReader.Close() | ||
| go func() { | ||
| _, _ = pipeWriter.Write([]byte(line)) | ||
| _, _ = reader.WriteTo(pipeWriter) | ||
| }() |
There was a problem hiding this comment.
I'm a bit confused about the purpose of the pipe here. Couldn't you just create a new bytes.Buffer from line and call reader.WriteTo(newBuf)?
There was a problem hiding this comment.
https://pkg.go.dev/bufio#Reader.Peek would work well here too
There was a problem hiding this comment.
Nah, bytes.Buffer will EOF if read, which we don't want. I had that initially too!
I was going to change the reader to peek, but it's an unknown amount of bytes until a newline, so it felt a bit off!
Going to merge, but if the above doesn't make sense just LMK!
There was a problem hiding this comment.
Interesting. Makes sense to me!
Fixes #492. There is no more single-quote parsing, and instead we use a JSON decoder for multiline values. This is a much better UX!