ci: Run peer tests faster on local machine #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should result in faster local development, and faster CI! See the code comment for rationale.
Codecov Report
@@ Coverage Diff @@
## main #54 +/- ##
==========================================
- Coverage 71.23% 71.14% -0.09%
==========================================
Files 60 60
Lines 2395 2395
Branches 30 30
==========================================
- Hits 1706 1704 -2
- Misses 537 539 +2
Partials 152 152
Continue to review full report at Codecov.
|
Comment on lines
+28
to
+39
| // Connection state is unfortunately time-based. When resources are | ||
| // contended, a connection can take greater than this timeout to | ||
| // handshake, which results in a test flake. | ||
| // | ||
| // During local testing resources are rarely contended. Reducing this | ||
| // timeout leads to faster local development. | ||
| // | ||
| // In CI resources are frequently contended, so increasing this value | ||
| // results in less flakes. | ||
| if os.Getenv("CI") == "true" { | ||
| return 4 * time.Second | ||
| } |
There was a problem hiding this comment.
Thanks for the descriptive comment 👍
bryphe-coder
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should result in faster local development, and faster CI!
See the code comment for rationale.