fix: Use upstream github.com/pion/ice dependency #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A forked version containing the following fix was used: pion/ice#411 This has been merged upstream! 馃コ
Codecov Report
@@ Coverage Diff @@
## main #55 +/- ##
==========================================
- Coverage 71.39% 71.23% -0.17%
==========================================
Files 60 60
Lines 2395 2395
Branches 30 30
==========================================
- Hits 1710 1706 -4
- Misses 534 537 +3
- Partials 151 152 +1
Continue to review full report at Codecov.
|
| @@ -84,7 +81,7 @@ require ( | |||
| github.com/opencontainers/image-spec v1.0.2 // indirect | |||
| github.com/opencontainers/runc v1.0.2 // indirect | |||
| github.com/pion/dtls/v2 v2.1.0 // indirect | |||
| github.com/pion/ice/v2 v2.1.18 // indirect | |||
| github.com/pion/ice/v2 v2.1.19 // indirect | |||
There was a problem hiding this comment.
馃帀 Nice that we don't have to use the fork anymore. Thanks for contributing the fix @kylecarbs !
bryphe-coder
approved these changes
Jan 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A forked version containing the following fix was used:
pion/ice#411
This has been merged upstream! 馃コ