feat: Update Coder Terraform Provider to v0.2.1 #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
force-pushed
the
updateprovider
branch
3 times, most recently
from
7eb968a
to
6ac3bbf
Compare
coadler
approved these changes
Mar 25, 2022
provisioner/terraform/provision.go
Outdated
| if instanceIDRaw, has := resource.Expressions["instance_id"]; has { | ||
| instanceID, ok := instanceIDRaw.ConstantValue.(string) | ||
| if !ok { | ||
| return nil, xerrors.Errorf("unexpected type %q for instance_id", reflect.TypeOf(instanceIDRaw.ConstantValue).String()) |
There was a problem hiding this comment.
you can use %T to print the type of a variable!
Codecov Report
@@ Coverage Diff @@
## main #563 +/- ##
==========================================
- Coverage 62.91% 62.87% -0.04%
==========================================
Files 194 194
Lines 11108 11107 -1
Branches 85 85
==========================================
- Hits 6989 6984 -5
- Misses 3359 3363 +4
Partials 760 760
Continue to review full report at Codecov.
|
This update exposes the workspace name and owner, and changes authentication methods to be explicit. Implicit authentication added unnecessary complexity and introduced inconsistency.
kylecarbs
force-pushed
the
updateprovider
branch
from
6ac3bbf
to
c4561d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update exposes the workspace name and owner, and changes
authentication methods to be explicit. Implicit authentication
added unnecessary complexity and introduced inconsistency.