Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Parsing dynamic values for agent results in error #564

Merged
merged 1 commit into from
Mar 25, 2022

Conversation

kylecarbs
Copy link
Member

The logic required a constant value before, which disallowed dynamic
value injection into the agent. This isn't an accurate limitation,
so inverting the logic resolves it.

@kylecarbs kylecarbs requested a review from coadler March 25, 2022 17:10
@kylecarbs kylecarbs self-assigned this Mar 25, 2022
The logic required a constant value before, which disallowed dynamic
value injection into the agent. This isn't an accurate limitation,
so inverting the logic resolves it.
@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #564 (73e9793) into main (a06821c) will increase coverage by 0.10%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##             main     #564      +/-   ##
==========================================
+ Coverage   63.00%   63.10%   +0.10%     
==========================================
  Files         194      108      -86     
  Lines       11107    10024    -1083     
  Branches       85        0      -85     
==========================================
- Hits         6998     6326     -672     
+ Misses       3354     2979     -375     
+ Partials      755      719      -36     
Flag Coverage Δ
unittest-go- 61.84% <50.00%> (+0.17%) ⬆️
unittest-go-macos-latest 57.56% <0.00%> (-0.14%) ⬇️
unittest-go-ubuntu-latest 60.79% <50.00%> (+0.03%) ⬆️
unittest-go-windows-2022 ?
unittest-js ?
Impacted Files Coverage Δ
provisioner/terraform/provision.go 75.27% <50.00%> (+0.67%) ⬆️
pty/ptytest/ptytest.go 94.82% <0.00%> (-5.18%) ⬇️
cli/projectinit.go 56.36% <0.00%> (-3.64%) ⬇️
coderd/workspaceresources.go 57.60% <0.00%> (-3.23%) ⬇️
provisioner/echo/serve.go 54.40% <0.00%> (-2.40%) ⬇️
provisionerd/provisionerd.go 80.32% <0.00%> (-0.66%) ⬇️
site/src/components/Form/FormCloseButton.tsx
site/src/components/Header/HeaderButton.tsx
site/src/components/SignIn/CliAuthToken.tsx
site/src/theme/global-fonts.ts
... and 87 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a06821c...73e9793. Read the comment docs.

@kylecarbs kylecarbs merged commit 21fdb80 into main Mar 25, 2022
@kylecarbs kylecarbs deleted the fixinstanceid branch March 25, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants