Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Separate workspace agent for tests #567

Merged
merged 1 commit into from
Mar 25, 2022
Merged

feat: Separate workspace agent for tests #567

merged 1 commit into from
Mar 25, 2022

Conversation

kylecarbs
Copy link
Member

This adds tests for Google Cloud authentication, and lays
the ground-work for future agent auth types in the future.

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #567 (1cf1805) into main (21fdb80) will increase coverage by 0.15%.
The diff coverage is 63.21%.

@@            Coverage Diff             @@
##             main     #567      +/-   ##
==========================================
+ Coverage   62.92%   63.07%   +0.15%     
==========================================
  Files         194      195       +1     
  Lines       11097    11205     +108     
  Branches       85       85              
==========================================
+ Hits         6983     7068      +85     
- Misses       3358     3373      +15     
- Partials      756      764       +8     
Flag Coverage Δ
unittest-go- 62.00% <63.21%> (+0.31%) ⬆️
unittest-go-macos-latest 58.01% <63.21%> (+0.70%) ⬆️
unittest-go-ubuntu-latest 61.16% <63.21%> (+0.35%) ⬆️
unittest-go-windows-2022 57.07% <63.21%> (+0.54%) ⬆️
unittest-js 63.32% <ø> (ø)
Impacted Files Coverage Δ
cli/ssh.go 5.12% <0.00%> (-1.33%) ⬇️
agent/conn.go 65.38% <65.38%> (ø)
codersdk/workspaceresources.go 59.59% <70.00%> (+1.57%) ⬆️
cli/workspaceagent.go 66.66% <92.59%> (+56.66%) ⬆️
agent/agent.go 67.45% <100.00%> (+0.22%) ⬆️
coderd/coderdtest/coderdtest.go 99.15% <100.00%> (+0.27%) ⬆️
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
provisionersdk/transport.go 74.46% <0.00%> (-4.26%) ⬇️
peer/conn.go 77.15% <0.00%> (-3.05%) ⬇️
provisioner/echo/serve.go 54.40% <0.00%> (-2.40%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21fdb80...1cf1805. Read the comment docs.

agent/conn.go Outdated
Protocol: "ssh",
})
if err != nil {
return nil, err
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing lots of wraps in this file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call. Dunno why I do that 🤦

This adds tests for Google Cloud authentication, and lays
the ground-work for future agent auth types in the future.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants