Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Move httpapi, httpmw, & database into coderd #568

Merged
merged 11 commits into from
Mar 25, 2022

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Mar 25, 2022

The goal is to keep all Coder specific packages in coderd. This draws some better boundaries on what these 3 packages can import themselves.

httpmw is specific to coderd and should be scoped under coderd
httpapi is specific to coderd and should be scoped under coderd
database is specific to coderd and should be scoped under coderd
@kylecarbs
Copy link
Member

We can take out (cdr) from the title, because there's only cdr now! Let's list the specific packages in the title too for easy historical records!

@Emyrk Emyrk changed the title chore(cdr): Move Coder specific pkgs into coderd chore: Move httpapi, httpmw, & database into coderd Mar 25, 2022
@Emyrk
Copy link
Member Author

Emyrk commented Mar 25, 2022

@kylecarbs makes sense. Habit from /m. Will defer semantic commit discussion for now. I still find value in tags, but agree the tag I put was redundant.

@codecov
Copy link

codecov bot commented Mar 25, 2022

Codecov Report

Merging #568 (457b21a) into main (6be949a) will increase coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #568      +/-   ##
==========================================
+ Coverage   63.55%   63.66%   +0.11%     
==========================================
  Files         195      195              
  Lines       11205    11205              
  Branches       85       85              
==========================================
+ Hits         7121     7134      +13     
+ Misses       3326     3317       -9     
+ Partials      758      754       -4     
Flag Coverage Δ
unittest-go- 62.57% <ø> (+0.29%) ⬆️
unittest-go-macos-latest 58.21% <ø> (+0.14%) ⬆️
unittest-go-ubuntu-latest 61.26% <ø> (+0.02%) ⬆️
unittest-go-windows-2022 57.10% <ø> (+<0.01%) ⬆️
unittest-js 63.32% <ø> (ø)
Impacted Files Coverage Δ
cli/cliui/job.go 66.66% <ø> (ø)
cli/parametercreate.go 30.35% <ø> (ø)
cli/projectcreate.go 48.71% <ø> (+1.92%) ⬆️
cli/projects.go 54.23% <ø> (ø)
cli/projectupdate.go 7.24% <ø> (ø)
cli/ssh.go 5.12% <ø> (ø)
cli/start.go 65.84% <ø> (ø)
cli/workspacecreate.go 35.15% <ø> (ø)
cli/workspacedelete.go 17.14% <ø> (ø)
cli/workspacestart.go 14.70% <ø> (ø)
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6be949a...457b21a. Read the comment docs.

Makefile Outdated Show resolved Hide resolved
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One extremely minor comment. Woooonderful cleanup of the structure!

Makefile Outdated Show resolved Hide resolved
@Emyrk Emyrk merged commit 591523a into main Mar 25, 2022
@Emyrk Emyrk deleted the stevenmasley/pkg_move_refactor branch March 25, 2022 21:07
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants