feat: Support caching provisioner assets #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows zero-trust authentication for all AWS instances. Prior to this, AWS instances could be used by passing `CODER_TOKEN` as an environment variable to the startup script. AWS explicitly states that secrets should not be passed in startup scripts because it's user-readable.
This caches the Terraform binary, and Terraform plugins. Eventually, it could cache other temporary files.
Codecov Report
@@ Coverage Diff @@
## main #574 +/- ##
==========================================
- Coverage 63.87% 63.67% -0.21%
==========================================
Files 197 197
Lines 11524 11537 +13
Branches 85 85
==========================================
- Hits 7361 7346 -15
- Misses 3389 3411 +22
- Partials 774 780 +6
Continue to review full report at Codecov.
|
coadler
approved these changes
Mar 26, 2022
|
@kylecarbs can this be closed or does it still need to be done? |
|
Erm there was no ticket for this @misskniss, so I'm not sure what you mean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caches the Terraform binary, and Terraform plugins.
Eventually, it could cache other temporary files.