Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initial Projects listing page #58

Merged
merged 10 commits into from
Jan 25, 2022

Conversation

bryphe-coder
Copy link
Contributor

@bryphe-coder bryphe-coder commented Jan 25, 2022

This implements a simple Project listing page at /projects - just a table for a list of projects:

image

...and an empty state:

image

There isn't too much data to show at the moment. It'll be nice in the future to show the following fields and improve the UI with it:

  • An icon
  • A list of users using the project
  • A description

However, this brings in a lot of scaffolding to make it easier to build pages like this (/organizations, /workspaces, etc).

In particular, I brought over a few things from v1:

  • The Hero / Header component at the top of pages + sub-components
  • A Table component for help rendering table-like UI + sub-components
  • Additional palette settings that the Hero

@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #58 (f6abb5f) into main (69d88b4) will decrease coverage by 0.56%.
The diff coverage is 61.68%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
- Coverage   72.27%   71.70%   -0.57%     
==========================================
  Files          71       79       +8     
  Lines        2795     2902     +107     
  Branches       36       49      +13     
==========================================
+ Hits         2020     2081      +61     
- Misses        604      645      +41     
- Partials      171      176       +5     
Flag Coverage Δ
unittest-go-macos-latest 67.35% <ø> (-0.44%) ⬇️
unittest-go-ubuntu-latest 70.50% <ø> (+0.08%) ⬆️
unittest-go-windows-latest 67.35% <ø> (+0.04%) ⬆️
unittest-js 73.10% <61.68%> (-3.46%) ⬇️
Impacted Files Coverage Δ
site/components/Table/index.tsx 0.00% <0.00%> (ø)
site/pages/projects/index.tsx 0.00% <0.00%> (ø)
site/theme/palettes.ts 100.00% <ø> (ø)
site/components/Header/HeaderButton.tsx 77.77% <77.77%> (ø)
site/components/Table/TableTitle.tsx 84.61% <84.61%> (ø)
site/components/Header/index.tsx 92.30% <92.30%> (ø)
site/components/ErrorSummary/index.tsx 100.00% <100.00%> (ø)
site/components/Table/Table.tsx 100.00% <100.00%> (ø)
site/components/Table/TableHeaders.tsx 100.00% <100.00%> (ø)
peerbroker/listen.go 80.46% <0.00%> (-2.35%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69d88b4...f6abb5f. Read the comment docs.

@bryphe-coder bryphe-coder marked this pull request as ready for review January 25, 2022 04:11
@bryphe-coder bryphe-coder self-assigned this Jan 25, 2022
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

site/pages/projects/index.tsx Show resolved Hide resolved
@bryphe-coder
Copy link
Contributor Author

Thanks for reviewing, @kylecarbs !

@bryphe-coder bryphe-coder merged commit b964cb0 into main Jan 25, 2022
@bryphe-coder bryphe-coder deleted the bryphe/feat/initial-projects-page branch January 25, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants