Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Validate workspace build parameters #5807

Merged
merged 38 commits into from
Jan 24, 2023
Merged

feat: Validate workspace build parameters #5807

merged 38 commits into from
Jan 24, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Jan 20, 2023 •
edited

Related: #5574

This PR enables coder_parameter validation on different levels: CLI, API and Terraform.

Changes:

  • feat: validate rich parameters passed via CLI
  • feat: add validation_error column to use on the CLI, API validation level
  • feat: update terraform-provider-coder to improve validation messages
  • feat: RichParameter's prompt for Options

@mtojek mtojek self-assigned this Jan 20, 2023
@mtojek mtojek mentioned this pull request Jan 20, 2023
Closed
@mtojek mtojek marked this pull request as ready for review January 24, 2023 12:48
@mtojek mtojek requested a review from kylecarbs January 24, 2023 12:48
kylecarbs
kylecarbs approved these changes Jan 24, 2023
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm happy we're using the same validation logic everywhere - should be a nice UX.

@mtojek mtojek merged commit 26c6952 into coder:main Jan 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 24, 2023
@bpmct bpmct added this to the Rich Parameters GA milestone Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
Rich Parameters GA
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mtojek @kylecarbs @bpmct