Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add authors to release notes #5834

Merged
merged 3 commits into from
Jan 25, 2023

Conversation

mafredri
Copy link
Member

This PR adds PR authors to release notes.

Currently co-authors are not supported, perhaps in a future enchancement.

## Changelog

### Features

- b045734b6 feat: Add use template button to template row (#5811) ([BrunoQuaresma](https://github.com/BrunoQuaresma))
- bbb208e29 feat: Add CLI support for workspace build parameters (#5768) ([mtojek](https://github.com/mtojek))
- 443e2180f feat: indicate when workspace builds are stopped/started by Coder (#5813) ([Kira-Pilot](https://github.com/Kira-Pilot))

### Bug fixes

- 0e58772f5 fix: filter workspace_build resource on start/stop action (#5809) ([Kira-Pilot](https://github.com/Kira-Pilot))
- 37628c8b5 fix: comment on winget PR correctly (#5789) ([deansheather](https://github.com/deansheather))
- d2ae16dd2 fix: routinely ping agent websocket to ensure liveness (#5824) ([coadler](https://github.com/coadler))
- c3731a1be fix: ensure agent websocket only removes its own conn (#5828) ([coadler](https://github.com/coadler))
- dbfeb5630 fix: update docs link for configuration (#5827) ([kylecarbs](https://github.com/kylecarbs))

### Documentation

- f67acac2b docs: updated diagram with git provider logos (#5816) ([sharkymark](https://github.com/sharkymark))

### Tests

- 6a245ab1c test: Fix GPG test so it does not inherit parent parallelism (#5820) ([mafredri](https://github.com/mafredri))

### Continuous integration

- 8a9661e3c ci: Add authors to release notes

### Chores

- 918c37c35 chore: Ignore expired at on chromatic (#5808) ([BrunoQuaresma](https://github.com/BrunoQuaresma))
- 8afdf24d1 chore: Update sqlc to v1.16.0 (#5788) ([mafredri](https://github.com/mafredri))
- 73afdd7c0 chore: agent_test.go: use ptty.Peek() instead of expecting caret in TestAgent_SessionTTYShell (#5821) ([johnstcn](https://github.com/johnstcn))
- ba8dd496c chore: manually specify templates to embed (#5823) ([kylecarbs](https://github.com/kylecarbs))
- 882832cc5 chore: removed FE code owners (#5826) ([Kira-Pilot](https://github.com/Kira-Pilot))

Compare: [`v0.15.1...v0.15.2`](https://github.com/coder/coder/compare/v0.15.1...v0.15.2)

## Container image

- `docker pull ghcr.io/coder/coder:v0.15.2`

@mafredri mafredri self-assigned this Jan 24, 2023
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that it makes working at Coder more like working on an OSS project. Neato!

line="- $commit ${COMMIT_METADATA_TITLE[$commit]}\n"
line="- $commit ${COMMIT_METADATA_TITLE[$commit]}"
if [[ -v COMMIT_METADATA_AUTHORS[$commit] ]]; then
line+=" (${COMMIT_METADATA_AUTHORS[$commit]})"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the markdown link make them show up as a contributor in the release (this is a newish GH feature)? If not we need to use @ instead I think

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no idea, but I can def. revert back to @

@mafredri mafredri merged commit 78ede50 into main Jan 25, 2023
@mafredri mafredri deleted the mafredri/ci-mention-contributors-in-release-notes branch January 25, 2023 09:13
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants