Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update to go 1.18 #628

Merged
merged 6 commits into from
Mar 28, 2022
Merged

chore: update to go 1.18 #628

merged 6 commits into from
Mar 28, 2022

Conversation

coadler
Copy link
Member

@coadler coadler commented Mar 28, 2022

No description provided.

@coadler coadler self-assigned this Mar 28, 2022
@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #628 (ce4039a) into main (eb18925) will decrease coverage by 0.23%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main     #628      +/-   ##
==========================================
- Coverage   63.53%   63.29%   -0.24%     
==========================================
  Files         195      112      -83     
  Lines       11215    10432     -783     
  Branches       85        0      -85     
==========================================
- Hits         7125     6603     -522     
+ Misses       3334     3079     -255     
+ Partials      756      750       -6     
Flag Coverage Δ
unittest-go- 62.42% <91.66%> (+0.25%) ⬆️
unittest-go-macos-latest 58.14% <66.66%> (-0.18%) ⬇️
unittest-go-ubuntu-latest 61.19% <66.66%> (+0.01%) ⬆️
unittest-go-windows-2022 57.35% <66.66%> (+0.22%) ⬆️
unittest-js ?
Impacted Files Coverage Δ
codersdk/client.go 50.64% <ø> (-5.20%) ⬇️
cli/cliui/select.go 45.71% <66.66%> (+1.96%) ⬆️
coderd/database/pubsub.go 77.77% <100.00%> (+0.69%) ⬆️
coderd/provisionerjobs.go 61.92% <100.00%> (+1.92%) ⬆️
codersdk/workspacebuilds.go 58.33% <0.00%> (-8.34%) ⬇️
peerbroker/dial.go 75.43% <0.00%> (-7.02%) ⬇️
coderd/workspacebuilds.go 55.31% <0.00%> (-6.39%) ⬇️
provisionersdk/transport.go 74.46% <0.00%> (-6.39%) ⬇️
peer/conn.go 76.64% <0.00%> (-4.07%) ⬇️
... and 98 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb18925...ce4039a. Read the comment docs.

@coadler coadler marked this pull request as ready for review March 28, 2022 18:55
@coadler coadler requested a review from kylecarbs March 28, 2022 18:56
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two minor nits. Hello generics!

Makefile Outdated Show resolved Hide resolved
coderd/provisionerjobs.go Outdated Show resolved Hide resolved
@coadler coadler enabled auto-merge (squash) March 28, 2022 19:08
@coadler coadler merged commit be8389f into main Mar 28, 2022
@coadler coadler deleted the colin/go1.18 branch March 28, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants