chore: update v1 schema #643
Conversation
Codecov Report
@@ Coverage Diff @@
## main #643 +/- ##
==========================================
+ Coverage 62.07% 64.06% +1.99%
==========================================
Files 113 199 +86
Lines 10755 11861 +1106
Branches 0 87 +87
==========================================
+ Hits 6676 7599 +923
- Misses 3296 3439 +143
- Partials 783 823 +40
Continue to review full report at Codecov.
|
coadler
force-pushed
the
colin/uuid-schema
branch
4 times, most recently
from
0f51d90
to
bd149b1
Compare
| httpapi.Write(rw, http.StatusNotFound, httpapi.Response{ | ||
| Message: fmt.Sprintf("organization %q does not exist", organizationID), | ||
| }) | ||
| orgID, ok := parseUUID(rw, r, "organization") |
There was a problem hiding this comment.
Why abbreviate here and not for organization? We should be consistent with abbreviations.
There was a problem hiding this comment.
I don't think it's necessarily important for local variables, organization is a lot to type every time. IMO it's only important for exported variables and function params.
There was a problem hiding this comment.
That's a bit of an arbitrarily drawn line though. It's more to type, but an inconsistent naming scheme hurts readability.
| @@ -46,31 +47,37 @@ func List() ([]Example, error) { | |||
| returnError = xerrors.Errorf("example %q does not contain README.md", exampleID) | |||
| return | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
I'd rather add a linting rule to enforce newline conventions. Arbitrarily doing it on a per-developer basis will read to inconsistency when reading our code.
coadler
force-pushed
the
colin/uuid-schema
branch
5 times, most recently
from
9a63ac3
to
2a61e73
Compare
| revoked boolean NOT NULL, | ||
| login_type login_type NOT NULL, |
There was a problem hiding this comment.
This is referenced a bunch in the code, I'd rather remove these after.
coadler
force-pushed
the
colin/uuid-schema
branch
from
2a61e73
to
da23bf5
Compare
Now uses UUIDs for users, organizations, organization members, and api keys. Also updates the v1 migration to correctly create indexes and foreign keys that were missed previously.