Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Fix path for creating initial user in dev script #69

Merged
merged 1 commit into from
Jan 25, 2022

Conversation

bryphe-coder
Copy link
Contributor

Just a small fix in the develop.sh script to pick up the new create initial user route

@bryphe-coder bryphe-coder self-assigned this Jan 25, 2022
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #69 (495d95c) into main (5b01f61) will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   71.17%   71.09%   -0.09%     
==========================================
  Files          82       82              
  Lines        3376     3376              
  Branches       49       49              
==========================================
- Hits         2403     2400       -3     
- Misses        768      770       +2     
- Partials      205      206       +1     
Flag Coverage Δ
unittest-go-macos-latest 67.45% <ø> (ø)
unittest-go-ubuntu-latest 69.98% <ø> (+0.13%) ⬆️
unittest-go-windows-latest 67.23% <ø> (-0.08%) ⬇️
unittest-js 73.10% <ø> (ø)
Impacted Files Coverage Δ
peer/conn.go 75.74% <0.00%> (-0.90%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b01f61...495d95c. Read the comment docs.

Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh right, forgot to change this!

Thanks Bryan 🥳

@bryphe-coder
Copy link
Contributor Author

Ahh right, forgot to change this!

Haha no worries! They came in at the same time, and its tough to find anyway! Maybe later we can have a simple E2E test that can catch this.

I read through the new endpoint and missed thinking about in your PR too... only realized when I ran it on latest main 😄

@bryphe-coder bryphe-coder merged commit ec144d9 into main Jan 25, 2022
@bryphe-coder bryphe-coder deleted the bryphe/refactor/user-creation-path branch January 25, 2022 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants